Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tslib version in package.json seems to be incorrect #1188

Closed
daku10 opened this issue May 16, 2020 · 3 comments
Closed

tslib version in package.json seems to be incorrect #1188

daku10 opened this issue May 16, 2020 · 3 comments
Labels
response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.

Comments

@daku10
Copy link

daku10 commented May 16, 2020

Describe the bug
A clear and concise description of what the bug is.

tslib dependencies in package.json seems to be incorrect.
Packages declare that they use Typescript@~3.8.3 and tslib@^1.8.0.
And some packages uses array spread operator, it is transpiled to code that uses __spreadArrays function of tslib by using typescript@~3.8.3.
But __spreadArrays function is instroduced tslib@1.10.0 release note
Therefore build of the packages is failed in some enviroment.

SDK version number

@aws-sdk/signature-v4@1.0.0-beta.4

Is the issue in the browser/Node.js?
Node.js

Details of the browser/Node.js version
Paste output of npx envinfo --browsers or node -v

v12.16.0

To Reproduce (observed behavior)
Steps to reproduce the behavior (please share code or minimal repo)

I cannot prepare minimal code to reproduce this issue, because this issue is related to environment.
So I create a repository which contains this issue to use aws-amplify-react.
yarn && yarn build may produce this issue.

Additional context
Add any other context about the problem here.

I have encountered this issue when I introduced ams-amplify-react to some old project which lockfile uses tslib@1.9.3 as tslib@^1.8.0.
I think tslib version should be upgraded to match typescript version.
Should I create PR for this issue?

@trivikr
Copy link
Member

trivikr commented Aug 25, 2020

tslib was bumped to 2.0.0 in #1417
typescript was bumped to 4.0.2 in #1456

Both updates are available in release v1.0.0-gamma.7
Is this issue still reproducible @daku10 ?

@trivikr trivikr added the response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days. label Aug 25, 2020
@daku10
Copy link
Author

daku10 commented Aug 27, 2020

@trivikr

In my environment, resolve this issue to update version.
Thanks!

@daku10 daku10 closed this as completed Aug 27, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
response-requested Waiting on additional info and feedback. Will move to \"closing-soon\" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants