Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump typescript to ~4.0.2 #1456

Merged
merged 3 commits into from Aug 20, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 20, 2020

Issue #, if available:
N/A

Description of changes:
TypeScript 4.0 availability announcement https://devblogs.microsoft.com/typescript/announcing-typescript-4-0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1456 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files         297      297           
  Lines       11480    11480           
  Branches     2470     2470           
=======================================
  Hits         9158     9158           
  Misses       2322     2322           
Impacted Files Coverage Δ
packages/util-create-request/src/foo.fixture.ts 76.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e34453...8e47034. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Aug 20, 2020

Build times tested on c5.4xlarge

  • Typescript 3.9.6: yarn build:all 8414.10s user 334.98s system 1526% cpu 9:33.24 total
  • TypeScript 4.0.2: yarn build:all 8632.66s user 344.20s system 1498% cpu 9:58.90 total

@alexforsyth
Copy link
Contributor

LGTM

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants