Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running yarn generate-clients modifies dependencies in client-s3 #1310

Closed
trivikr opened this issue Jun 30, 2020 · 3 comments
Closed

Running yarn generate-clients modifies dependencies in client-s3 #1310

trivikr opened this issue Jun 30, 2020 · 3 comments

Comments

@trivikr
Copy link
Member

trivikr commented Jun 30, 2020

Describe the bug
Running yarn generate-clients modifies dependencies in client-s3 as shown in the screenshot below

diff
diff --git a/clients/client-s3/package.json b/clients/client-s3/package.json
index 7a319a0f1..45f0c559c 100644
--- a/clients/client-s3/package.json
+++ b/clients/client-s3/package.json
@@ -41,7 +41,6 @@
     "@aws-sdk/hash-node": "1.0.0-gamma.1",
     "@aws-sdk/hash-stream-node": "1.0.0-gamma.1",
     "@aws-sdk/invalid-dependency": "1.0.0-gamma.1",
-    "@aws-sdk/karma-credential-loader": "1.0.0-gamma.0",
     "@aws-sdk/md5-js": "1.0.0-gamma.1",
     "@aws-sdk/middleware-apply-body-checksum": "1.0.0-gamma.1",
     "@aws-sdk/middleware-bucket-endpoint": "1.0.0-gamma.1",
@@ -80,6 +79,7 @@
     "@types/chai": "^4.2.11",
     "@types/mocha": "^7.0.2",
     "@types/node": "^12.7.5",
+    "jest": "^25.1.0",
     "rimraf": "^3.0.0",
     "tslib": "^1.8.0",
     "typedoc": "^0.15.0",

To Reproduce (observed behavior)
Run generate-clients for all clients or just s3:

  • yarn generate-clients
  • yarn generate-clients -g codegen/sdk-codegen/aws-models/s3.2006-03-01.json

Expected behavior
The package.json shouldn't be modified for client-s3

Screenshots

Screenshot Screen Shot 2020-06-30 at 2 39 31 PM
@trivikr
Copy link
Member Author

trivikr commented Jun 30, 2020

Related to #1296

@trivikr
Copy link
Member Author

trivikr commented Sep 15, 2020

Fixed in #1207

@trivikr trivikr closed this as completed Sep 15, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant