chore: allow un-overwritable scripts and devDependencies in package.json #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And pin the version of internal dependencies "@aws-sdk/*"
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
requested changes
May 27, 2020
Comment on lines
+75
to
+86
| const pinDependencies = manifest => { | ||
| const removeRangeVersion = ([name, version]) => | ||
| name.indexOf("@aws-sdk/") === 0 | ||
| ? [name, version.replace("^", "")] | ||
| : [name, version]; | ||
| manifest.dependencies = Object.fromEntries( | ||
| Object.entries(manifest.dependencies).map(removeRangeVersion) | ||
| ); | ||
| manifest.devDependencies = Object.fromEntries( | ||
| Object.entries(manifest.devDependencies).map(removeRangeVersion) | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Optional: use functions all the way to avoid mutating manifest and having small functions
const filterAwsSdkDeps = (name) => name.indexOf("@aws-sdk/") === 0;
const removeCaretFromDepVersion = (version) => version.replace("^", "");
const getPinnedAwsSdkDeps = (deps) => ({
...deps,
...Object.entries(deps)
.filter(([name, version]) => filterAwsSdkDeps(name))
.reduce(
(acc, [name, version]) => ({
...acc,
[name]: removeCaretFromDepVersion(version),
}),
{}
),
});
const getManifestWithPinnedAwsSdkDeps = (manifest) => ({
...manifest,
dependencies: getPinnedAwsSdkDeps(manifest.dependencies),
devDependencies: getPinnedAwsSdkDeps(manifest.devDependencies),
});
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
May 28, 2020
|
Merging to unblock #1218 |
trivikr
changed the title
This was referenced May 28, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 changes with this PR:
If a client's package.json contains a local NPM
scriptsordevDependencies, they would be removed by codegen because these new entries don't exist package.json's template. This change avoids removing these entries.What is not changed: for the entries in
scriptsordevDependenciesand exist in both newly generated client and existing client, the script prefers the ones in existing client.Temporarily pin the newly added internal dependencies version. We will review this before GA.(maybe re-introduce the range dependencies)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.