Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot view CI build status of my own PR #1463

Closed
justingrant opened this issue Aug 25, 2020 · 5 comments
Closed

Cannot view CI build status of my own PR #1463

justingrant opened this issue Aug 25, 2020 · 5 comments
Assignees

Comments

@justingrant
Copy link
Contributor

justingrant commented Aug 25, 2020

Describe the bug
When filing a PR on this repo (e.g. #1462), if builds fail then I'm unable to view the build results. This means that I can't figure out exactly what's failing. This is especially problematic now because #1460 prevents local builds and testing from working.

SDK version number
n/a

Is the issue in the browser/Node.js/ReactNative?
n/a

Details of the browser/Node.js/ReactNative version
n/a

To Reproduce (observed behavior)
File any PR when you're not an AWS employee

Actual behavior
I don't have permission to view CI build results.

Expected behavior
I can view CI build results

Screenshots
image

https://us-west-2.console.aws.amazon.com/codesuite/codebuild/138827292993/projects/sdk-staging-test/build/sdk-staging-test%3A13bfb14f-b7d8-49de-9d41-12449a757415

image

Additional context
I'm not sure if CodeBuild permissions can be edited to allow public read-only access, but that'd seem like the logical fix here. Not sure why an open-source project should have any build artifacts closed to the public.

@trivikr
Copy link
Member

trivikr commented Aug 25, 2020

History:

We either need to re-enable github-codebuild-logs or revisit GitHub Actions.

@justingrant
Copy link
Contributor Author

OK, thanks @trivikr for the update. I don't know which of those options would be best.

In the meantime, would it be possible to let me know if #1462 has build failures other than the memory exhaustion caused by #1460? If there are non-#1460 failures, I'll fix them!

@trivikr
Copy link
Member

trivikr commented Aug 25, 2020

would it be possible to let me know if #1462 has build failures other than the memory exhaustion caused by #1460?

Yup, it's memory exhaustion failure caused by #1460

@trivikr
Copy link
Member

trivikr commented Jan 5, 2021

Closing, as github-codebuild-logs was re-enabled on aws-sdk-js-v3.
Example comment: #1863 (comment)

@trivikr trivikr closed this as completed Jan 5, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants