Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jun 15, 2020

Issue #, if available:
N/A

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Jun 15, 2020

Verified that GitHub CodeBuild output is streamed to Checks tab

Screenshot

Screen Shot 2020-06-15 at 4 02 41 PM

@trivikr
Copy link
Member Author

trivikr commented Jun 15, 2020

Steps to take after this PR is merged:

  • Delete serverlessrepo-github-codebuild-logs-v3 Cloudformation stack which helps in sharing CodeBuild logs as comments
    • Reason: it's replaced by GitHub Action
  • Delete sdk-staging-test CodeBuild project
    • Reason: it's replaced by aws-sdk-js-modular-pr-test

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve again!

@aws-sdk-js-automation

This comment has been minimized.

@codecov-commenter
Copy link

Codecov Report

Merging #1265 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   73.32%   72.98%   -0.35%     
==========================================
  Files         289      286       -3     
  Lines       12724    12699      -25     
  Branches     2920     2915       -5     
==========================================
- Hits         9330     9268      -62     
- Misses       3394     3431      +37     
Impacted Files Coverage Δ
packages/fetch-http-handler/src/request-timeout.ts 14.28% <0.00%> (-85.72%) ⬇️
...kages/fetch-http-handler/src/fetch-http-handler.ts 15.55% <0.00%> (-80.00%) ⬇️
packages/hash-node/src/index.ts 100.00% <0.00%> (ø)
packages/middleware-retry/src/delayDecider.ts 100.00% <0.00%> (ø)
packages/middleware-retry/src/configurations.ts 100.00% <0.00%> (ø)
packages/middleware-retry/src/defaultStrategy.ts 100.00% <0.00%> (ø)
packages/util-base64-universal/src/index.ts
packages/is-node/src/index.ts
packages/util-utf8-universal/src/index.ts
packages/middleware-retry/src/retryMiddleware.ts 100.00% <0.00%> (+38.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd48130...c8b7a04. Read the comment docs.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants