Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target ES2018 for commonjs packages #1559

Closed
trivikr opened this issue Oct 12, 2020 · 2 comments · Fixed by #1573
Closed

Target ES2018 for commonjs packages #1559

trivikr opened this issue Oct 12, 2020 · 2 comments · Fixed by #1573
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Oct 12, 2020

Is your feature request related to a problem? Please describe.
We're now targeting Node.js >=10.0.0: #1558

Node.js >10.0.0 supports 100% of ES2018:

The tsconfig.json in clients still target "es2017":

Describe the solution you'd like
Target "ES2018" as we support Node.js >=10.0.0, so that cjs bundle size reduces.

Describe alternatives you've considered
Sticking with target ES2017, as it runs on Node.js >=10.0.0.

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Oct 12, 2020
@trivikr
Copy link
Member Author

trivikr commented Oct 14, 2020

PRs:

@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant