Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: target ES2018 in packages #1562

Merged
merged 5 commits into from Oct 14, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 12, 2020

Issue #, if available:
Refs: #1559

Description of changes:
target ES2018 in packages

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #1562 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
+ Coverage   79.84%   79.87%   +0.03%     
==========================================
  Files         304      312       +8     
  Lines       11753    11843      +90     
  Branches     2511     2503       -8     
==========================================
+ Hits         9384     9460      +76     
- Misses       2369     2383      +14     
Impacted Files Coverage Δ
...-provider-cognito-identity/src/IndexedDbStorage.ts 6.52% <0.00%> (-12.63%) ⬇️
packages/signature-v4/src/moveHeadersToQuery.ts 90.00% <0.00%> (-10.00%) ⬇️
packages/smithy-client/src/client.ts 76.47% <0.00%> (-7.74%) ⬇️
...kages/fetch-http-handler/src/fetch-http-handler.ts 9.52% <0.00%> (-6.76%) ⬇️
...s/middleware-bucket-endpoint/src/configurations.ts 95.65% <0.00%> (-4.35%) ⬇️
...ventstream-marshaller/src/EventStreamMarshaller.ts 91.66% <0.00%> (-4.34%) ⬇️
packages/xml-builder/src/XmlNode.ts 88.00% <0.00%> (-4.31%) ⬇️
packages/middleware-ssec/src/index.ts 82.60% <0.00%> (-2.58%) ⬇️
...dleware-bucket-endpoint/src/bucketHostnameUtils.ts 96.42% <0.00%> (-1.91%) ⬇️
...-sdk-transcribe-streaming/src/websocket-handler.ts 78.33% <0.00%> (-1.67%) ⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afe767...f423d7a. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants