Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common values in packages/* tsconfig files to root TSConfig #1563

Closed
trivikr opened this issue Oct 12, 2020 · 1 comment
Closed

Move common values in packages/* tsconfig files to root TSConfig #1563

trivikr opened this issue Oct 12, 2020 · 1 comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Oct 12, 2020

Is your feature request related to a problem? Please describe.
There are multiple values in packages/* tsconfig files which can be moved to root and only uncommon values can be overwritten.

For example,

  • "strict": true is present in 81/85 packages
  • "sourceMap": false is present in 81/85 packages
  • "declaration": true is present in 84/85 packages
  • "importHelpers": true is present in 83/85 packages
  • "noEmitHelpers": true is present in 83/85 packages
  • "inlineSourceMap": true is present in 81/85 packages
  • "inlineSources": true is present in 81/85 packages

Describe the solution you'd like
Move these values to root TSConfig instead.

Describe alternatives you've considered
Sticking with most common TSConfig values defined in individual packages.

Additional context
This issue was noticed while updating target to ES2018 in packages/* in #1562

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Oct 12, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

2 participants