Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish commonjs packages for modules which should be used in the browser #1571

Closed
trivikr opened this issue Oct 14, 2020 · 2 comments
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Oct 14, 2020

Is your feature request related to a problem? Please describe.
The packages which should only be used in browsers are publishing commonjs modules. For example:

Describe the solution you'd like
Do not publish commonjs packages for modules which should be used in the browser.

Describe alternatives you've considered
Stick with the commonjs packages published for browsers. Users might mistakenly try to use them in Node.js in future.

Additional context
This issue was noticed while moving to ES2018 in #1562

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Oct 14, 2020
@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 15, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

1 participant