Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeGen reorders interface properties #1683

Closed
trivikr opened this issue Nov 13, 2020 · 1 comment · Fixed by smithy-lang/smithy-typescript#254
Closed

CodeGen reorders interface properties #1683

trivikr opened this issue Nov 13, 2020 · 1 comment · Fixed by smithy-lang/smithy-typescript#254
Assignees
@AllanZhengYP
Labels
High Priority
Projects
High Priority

Comments

@trivikr
Copy link
Member

trivikr commented Nov 13, 2020

Describe the bug
CodeGen reorders interface properties.

Example commit https://github.com/aws/aws-sdk-js-v3/pull/1676/files#diff-fc558d17069e9da5cd0f17e2de04f4b16730dc3d5ad52fc53db2f5d27c1a90f9

SDK version number
master

Is the issue in the browser/Node.js/ReactNative?
N/A

Details of the browser/Node.js/ReactNative version
N/A

To Reproduce (observed behavior)
Examine the example commit https://github.com/aws/aws-sdk-js-v3/pull/1676/files#diff-fc558d17069e9da5cd0f17e2de04f4b16730dc3d5ad52fc53db2f5d27c1a90f9

Expected behavior
The CodeGen shouldn't reorder interface properties.
@AllanZhengYP AllanZhengYP mentioned this issue Nov 13, 2020
Merged
@AllanZhengYP AllanZhengYP added this to Awaiting Triage in High Priority Nov 18, 2020
@AllanZhengYP AllanZhengYP self-assigned this Nov 23, 2020
This was referenced Dec 22, 2020
Closed
Merged
High Priority automation moved this from Awaiting Triage to Done Dec 23, 2020
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AllanZhengYP AllanZhengYP

Labels
High Priority
Projects
High Priority
Done
Milestone
No milestone
2 participants
@AllanZhengYP @trivikr