Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use LinkedHashSet for structure members #254

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Dec 23, 2020

Issue #, if available:
Fixes: aws/aws-sdk-js-v3#1683

Description of changes:
use LinkedHashSet to retain structure members' iteration order.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alexforsyth
Copy link
Contributor

Nice! This should really cut down on the diffs

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit b21e3b6 into smithy-lang:master Dec 23, 2020
@trivikr trivikr deleted the structure-members-linkedhashset branch December 23, 2020 17:55
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeGen reorders interface properties
3 participants