Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware-endpoint-discovery): add middleware for Endpoint Discovery #2369

Merged
merged 14 commits into from
May 14, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 9, 2021

Issue

Refs: #2211

Description

Adds middleware for Endpoint Discovery.
The base branch for this PR would be changed to main after #2355 is merged.

Testing

Unit tests added.
Testing also done with PoC code in #2339


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@f164177). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2369   +/-   ##
=======================================
  Coverage        ?   59.09%           
=======================================
  Files           ?      490           
  Lines           ?    26160           
  Branches        ?     6201           
=======================================
  Hits            ?    15460           
  Misses          ?    10700           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f164177...2583edc. Read the comment docs.

@trivikr trivikr marked this pull request as draft May 10, 2021 17:21
@trivikr trivikr force-pushed the middleware-endpoint-discovery branch from cd4c95c to 2977be8 Compare May 11, 2021 23:25
@trivikr trivikr changed the base branch from endpoint-cache-base to main May 11, 2021 23:25
@trivikr trivikr marked this pull request as ready for review May 11, 2021 23:26
@trivikr trivikr requested a review from AllanZhengYP May 11, 2021 23:26
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving it with minor doc feedbacks.

Co-authored-by: AllanZhengYP <zheallan@amazon.com>
@trivikr trivikr merged commit 7f297dc into aws:main May 14, 2021
@trivikr trivikr deleted the middleware-endpoint-discovery branch May 14, 2021 17:25
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants