feat(endpoint-cache): add EndpointCache for Endpoint Discovery #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage ? 60.15%
=======================================
Files ? 473
Lines ? 24900
Branches ? 5894
=======================================
Hits ? 14978
Misses ? 9922
Partials ? 0 Continue to review full report at Codecov.
|
In future, the callee may want to get all unexpired endpoints and add their own logic as more weights and priorities are added.
The callee will make decision based on value in Expires parameter as per SDK enhancement proposal.
TimeStream Service Developer Guide refers to CachePeriodInMinutes as Time to Live (TTL) value. It also specifies calls to be made for the duration of TTL. Refs: https://a.co/2e8J7xT
AllanZhengYP
approved these changes
May 11, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #2211
Description
adds EndpointCache for Endpoint Discovery:
mnemonist/lru-cachefor storing the cache.setoperation stores milliseconds elapsed since the UNIX epoch in Expires param based on CachePeriodInMinutes provided in Endpoint.getoperation returns a random un-expired endpoint.Testing
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.