Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deno] smithy-client fails to build #2597

Closed
christophgysin opened this issue Jul 19, 2021 · 2 comments · Fixed by #2598
Closed

[deno] smithy-client fails to build #2597

christophgysin opened this issue Jul 19, 2021 · 2 comments · Fixed by #2598
Assignees
@AllanZhengYP
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@christophgysin
Copy link
Contributor

christophgysin commented Jul 19, 2021 •
edited

Describe the bug

I'm maintaining a fork of aws-sdk-js-v3 for deno.

Commit fa60bf3 moved some types to a separate package that are then re-exported in smithy-client. This causes deno to fail while compiling typescript, with the error:

error: TS1205 [ERROR]: Re-exporting a type when the '--isolatedModules' flag is provided
requires using 'export type'.
export { DocumentType, SdkError, SmithyException } from "../types/mod.ts";
         ~~~~~~~~~~~~
@christophgysin christophgysin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 19, 2021
christophgysin added a commit to christophgysin/aws-sdk-js-v3 that referenced this issue Jul 19, 2021
@christophgysin
fix(smithy-client): export type explicitly
43b33c5 
fixes aws#2597
@christophgysin christophgysin mentioned this issue Jul 19, 2021
Merged
@AllanZhengYP AllanZhengYP self-assigned this Jul 19, 2021
@christophgysin
Copy link
Contributor Author

christophgysin commented Jul 20, 2021 •
edited

This typescript error is caused by deno's strict tsconfig, introduced in deno-1.5

The relevant typescript compiler option is isolatedModules.

AllanZhengYP pushed a commit that referenced this issue Jul 21, 2021
@christophgysin
fix(smithy-client): export type explicitly (#2598)
e643735 
fixes #2597
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Linkgoron pushed a commit to Linkgoron/aws-sdk-js-v3 that referenced this issue Jan 26, 2022
@christophgysin
fix(smithy-client): export type explicitly (aws#2598)
33a5298 
fixes aws#2597
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AllanZhengYP AllanZhengYP

Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(smithy-client): export type explicitly christophgysin/aws-sdk-js-v3
2 participants
@christophgysin @AllanZhengYP