Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smithy-client): export type explicitly #2598

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

christophgysin
Copy link
Contributor

@christophgysin christophgysin commented Jul 19, 2021

Issue

fixes #2597

Description

Explicitly re-export types using export type ...

Testing

Successfully built it locally with both yarn build:all and deno.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 43b33c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP
Copy link
Contributor

Why is export type required here? Is it specific to the converter of Deno SDK?

@christophgysin
Copy link
Contributor Author

christophgysin commented Jul 20, 2021

@AllanZhengYP This is not specific to deno, but the typescript configuration used by deno exposes it:

{
  "compilerOptions": {
    "isolatedModules": true
  }
}

You can see the actual typescript compiler error in the linked issue.

@AllanZhengYP AllanZhengYP merged commit e643735 into aws:main Jul 21, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deno] smithy-client fails to build
3 participants