-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client-s3): revert MRAP customizations #2759
Conversation
The @aws-sdk/client-s3@3.29.0 released with MRAP customization that instroduces `aws-crt` dependency. The dependency takes up too much disk space that blocks Lambda users deploying S3 client with certain deployers. Rollback the change to unblock these users. The MRAP users that's not affected by the dependency size can ping to the older version `@aws-sdk/client-s3@3.29.0`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong account. Sorry...
aws-crt also dramatically complicates using the SDK, as it introduces native code compilation. Glad to see this reverted. |
This reverts commit cfb3fff.
This reverts commit cfb3fff.
…s point (#2796) * Revert "fix(client-s3): revert MRAP customizations (#2759)" This reverts commit cfb3fff. * chore: update mrap packages dependencies * feat(middleware-sdk-s3): dynamically import aws-crt package optional dependencies * feat(middleware-user-agent): track if aws-crt is available at runtime * chore: update crt signer loading error message * chore(middleware-sdk-s3): add crt package to dev dependency and track usage This makes sure the type of CRT package is available and the Lerna builds packages in right order--build crt signer package before buiding s3 middleware package. * docs(client-s3): add docs to Bucket members on using MRAP * chore(signature-v4-crt): update crt version to ^1.9.7 * fix(client-s3): address PR feedbacks
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Reverts 3d07ed2, 49da47b
The
@aws-sdk/client-s3@3.29.0
released with MRAP dataplane customization that instroducesaws-crt
dependency. The dependency takes up too much disk space that blocksLambda users deploying S3 client with certain deployers.
Rollback the change to unblock these users. The MRAP users that's not affected
by the dependency size can ping to the older version
@aws-sdk/client-s3@3.29.0
Issue
Resolves #2750 #2747
Testing
TBD
Additional context
P52174768
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.