Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-s3): remove int validation of object size type #2775

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Sep 10, 2021

Issue

Resolves: #2751
Reference: aws/aws-sdk-go-v2#767

Description

Add customization to S3 model to change Size shape from integer to long. This will unblock the object size longer than the integer range.

This customization needs to removed when the model is fixed.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #2775 (62dcfc4) into main (a3e3927) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2775   +/-   ##
=======================================
  Coverage   60.15%   60.15%           
=======================================
  Files         548      548           
  Lines       28586    28586           
  Branches     6997     6997           
=======================================
  Hits        17196    17196           
  Misses      11390    11390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e3927...62dcfc4. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 5f2f70b into aws:main Sep 10, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 ListObjectsV2Command throws an error when a file size(in bytes) exceed 32-bit integer
3 participants