Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): move source files to 'src' folder #2845

Merged
merged 11 commits into from
Sep 29, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 29, 2021

Issue

Fixes: #1306

Note: This PR would be rebased from main after #2844 is merged. PR is ready for review!

Description

Moves source files in clients to 'src' folder

Testing

✅ CI is successful.

✅ Integration tests are successful.

  • yarn test:integration
  • yarn test:integration-legacy

✅ Mocha unit tests are successful.

  • client-lexruntime-service
  • client-mediastore-data
  • client-s3-control
  • client-s3

ToDo after merge: DryRun release after merging this PR.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #2845 (c46bb0b) into main (38bb6c3) will not change coverage.
The diff coverage is n/a.

❗ Current head c46bb0b differs from pull request most recent head bffb5a2. Consider uploading reports for the commit bffb5a2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2845   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files         554      554           
  Lines       28886    28886           
  Branches     7072     7072           
=======================================
  Hits        17453    17453           
  Misses      11433    11433           
Impacted Files Coverage Δ
...-s3-control/commands/DeleteBucketTaggingCommand.ts
...sts/aws-restxml/commands/RecursiveShapesCommand.ts
...ests/aws-query/commands/NestedStructuresCommand.ts
protocol_tests/aws-ec2/endpoints.ts
...ient-s3-control/commands/UpdateJobStatusCommand.ts
protocol_tests/aws-ec2/commands/XmlEnumsCommand.ts
...ests/aws-query/commands/NoInputAndOutputCommand.ts
protocol_tests/aws-ec2/models/models_0.ts
clients/client-s3-control/endpoints.ts
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts
... and 586 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcdeb6...bffb5a2. Read the comment docs.

for dir in ./clients/*; do (cd "$dir" && rm -rf *.ts commands models pagination protocols waiters); done
for dir in ./protocol_tests/*; do (cd "$dir" && rm -rf *.ts commands models pagination protocols waiters tests); done
foreach parentDir ("clients" "protocol_tests")
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/\/dist\//\/dist-*/g' ./.gitignore); done
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/runtimeConfig/dist-es\/runtimeConfig/g' ./package.json); done
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/dist\//dist-/g' ./package.json); done
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/dist\//dist-/g' ./tsconfig.*); done
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/"outDir"/"rootDir":"src","outDir"/' ./tsconfig.json); done
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/^}$/,"exclude": ["test\/**\/*"]}/' ./tsconfig.json); done
  for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/^}$/,"exclude": ["test\/**\/*", "dist-types\/**\/*"]}/' ./tsconfig.types.json); done
end
@trivikr trivikr marked this pull request as ready for review September 29, 2021 17:45
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Cleaned up all the mess in our published package 🧹

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move source files to "src" folder in clients
3 participants