Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): use esprint to eslint --fix clients source code #2846

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 29, 2021

Issue

Follow-up to #2838 which ran eslint in series.

This PR will be made ready for review after source code is moved to src folder in #2845 PR is ready

Description

Adds script to eslint --fix clients source code in parallel

Before
$ time yarn generate-clients
...
Done in 68.60s.
yarn generate-clients  10.74s user 2.37s system 19% cpu 1:08.73 total
After
$ time yarn generate-clients
...
Done in 111.67s.
yarn generate-clients  15.69s user 2.66s system 16% cpu 1:51.80 total

Testing

Verified that source code is linted in #2849


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #2846 (a09df69) into main (cfcdeb6) will not change coverage.
The diff coverage is n/a.

❗ Current head a09df69 differs from pull request most recent head 228aeda. Consider uploading reports for the commit 228aeda to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files         554      554           
  Lines       28886    28886           
  Branches     7072     7072           
=======================================
  Hits        17453    17453           
  Misses      11433    11433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0025cd...228aeda. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we can lint our generated clients! Just remove the extra comment

scripts/generate-clients/index.js Outdated Show resolved Hide resolved
@trivikr trivikr marked this pull request as ready for review September 29, 2021 18:13
@trivikr trivikr merged commit 65922ea into aws:main Sep 29, 2021
@trivikr trivikr deleted the test-esprint branch September 29, 2021 18:30
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants