Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-bucket-endpoint): remove dualstack from hostname before processing #3003

Merged
merged 4 commits into from
Nov 8, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 8, 2021

Issue

Fixes #3001
Fixes #3002

Description

Removes dualstack from hostname before processing

Testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #3003 (ad25cec) into main (f2fb280) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3003   +/-   ##
=======================================
  Coverage   58.77%   58.77%           
=======================================
  Files         567      567           
  Lines       30364    30366    +2     
  Branches     7483     7484    +1     
=======================================
+ Hits        17845    17847    +2     
  Misses      12519    12519           
Impacted Files Coverage Δ
...s/middleware-bucket-endpoint/src/bucketHostname.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2fb280...ad25cec. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it!

@trivikr trivikr merged commit d7aa2c3 into aws:main Nov 8, 2021
@trivikr trivikr deleted the remove-dualstack-before-processing branch November 8, 2021 19:51
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants