feat(rds-signer): add RDS Signer (#1823)

[jgoeglein]

Issue

#1823

Description

Adds RDS Signer for generating a password that can be used for IAM authentication. Previously, this functionality existed in v2.

Testing

1. Unit tests
2. Built and published tgz locally and deployed project using new module via CDK to verify functionality. Example manual implementation that was tested is located in this branch

Additional context

n/a

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[AllanZhengYP]

This very solid start! The interface is mostly complatible with the v2 SDK, which is good. I only have a few suggestions/questions.

[AllanZhengYP]

Some dependencies gone missing here: like @aws-sdk/credential-provider-node, @aws-crypto/sha256-js. This is causing the CI build to fail.

[AllanZhengYP]

@jgoeglein Can you move this package to the packages folder? The libs folder are supposed for abstructions beyond the 1:1 mapping of service APIs. The package doesn't qualify it.

[codecov-commenter]

Codecov Report

Merging #3084 (83ec3ce) into main (f6a3ef5) will decrease coverage by 16.46%.
The diff coverage is n/a.

❗ Current head 83ec3ce differs from pull request most recent head e2ed026. Consider uploading reports for the commit e2ed026 to get more accurate results

@@             Coverage Diff             @@
##             main    #3084       +/-   ##
===========================================
- Coverage   75.19%   58.72%   -16.47%     
===========================================
  Files         474      571       +97     
  Lines       20721    30622     +9901     
  Branches     4755     7541     +2786     
===========================================
+ Hits        15581    17984     +2403     
- Misses       5140    12638     +7498     

Impacted Files	Coverage Δ
...ages/middleware-sdk-s3/src/throw-200-exceptions.ts	90.00% <0.00%> (-3.34%)	⬇️
private/aws-protocoltests-ec2/src/endpoints.ts	100.00% <0.00%> (ø)
private/aws-protocoltests-json/src/endpoints.ts	100.00% <0.00%> (ø)
private/aws-protocoltests-query/src/endpoints.ts	100.00% <0.00%> (ø)
private/aws-protocoltests-ec2/src/runtimeConfig.ts	100.00% <0.00%> (ø)
private/aws-protocoltests-json-10/src/endpoints.ts	100.00% <0.00%> (ø)
private/aws-protocoltests-restxml/src/endpoints.ts	100.00% <0.00%> (ø)
...rivate/aws-protocoltests-json/src/runtimeConfig.ts	100.00% <0.00%> (ø)
...rivate/aws-protocoltests-restjson/src/endpoints.ts	100.00% <0.00%> (ø)
...ivate/aws-protocoltests-query/src/runtimeConfig.ts	100.00% <0.00%> (ø)
... and 108 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51aaffc...e2ed026. Read the comment docs.

[benasher44]

We're now using this implementation in our project. It'd be great to see this finally merged and rolled into the main SDK, so that we can re-shuffle our explicit dependencies 🙏

[AllanZhengYP]

Sorry for waiting so long before I reviewing it again! The PR is in a good shape now. I only have 2 very minor comments. Do you plan to take them? or I can push some commits to this branch.

/cc @jgoeglein

[jgoeglein]

Sorry for waiting so long before I reviewing it again! The PR is in a good shape now. I only have 2 very minor comments. Do you plan to take them? or I can push some commits to this branch.

/cc @jgoeglein

@AllanZhengYP Added you as a collaborator so you can push those changes - it might take me a few days to get back around to this, but happy to do so if needed.

[AllanZhengYP]

Okay, I will take it up. For easier interface, I plan to make this signer populating the default credential and region automatically. I post a separate PR #3588 to add an easier interface of Node.js default credential provider. I will update thie PR after that one merged.

[AllanZhengYP]

According to the latest offline discussion, we decided to standardize all the naming scheme to the signers packages like s3-request-presigner, polly-request-presigner, and cloudfront-request-presigner, because some of them doesn't actually presign a request.

For this package, we decided to keep the name as rds-signer, and keep the operation name as getAuthToken().

[bfaulk96]

Really looking forward to this addition – Not a fan of importing the entire aws-sdk simply to grab an IAM RDS password 😅

Thanks for all your hard work!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.