Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds-signer): update package.json with latest values #3632

Merged
merged 1 commit into from
May 24, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 24, 2022

Issue

Internal V588934046

Description

The PR which added rds-signer #3084 did not have latest changes in package.json

For example, our release automation failed with:

$ node --es-module-specifier-resolution=node ./scripts/downlevel-dts
The "build:types:downlevel" script is not defined for "packages/rds-signer"
undefined:0

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at validateString (internal/validators.js:124:11)
    at join (path.js:1148:7)
    at downlevelWorkspace (file:///codebuild/output/src466179555/src/aws-sdk-js-v3/scripts/downlevel-dts/downlevelWorkspace.mjs:27:24)
    at async file:///codebuild/output/src466179555/src/aws-sdk-js-v3/scripts/downlevel-dts/index.mjs:21:3 {
  code: 'ERR_INVALID_ARG_TYPE'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This PR adds those latest changes.

Testing

  • Build happens concurrently
Details
$ yarn build
yarn run v1.22.18
$ concurrently 'yarn:build:cjs' 'yarn:build:es' 'yarn:build:types'
$ tsc -p tsconfig.cjs.json
$ tsc -p tsconfig.es.json
$ tsc -p tsconfig.types.json
[build:cjs] yarn run build:cjs exited with code 0
[build:es] yarn run build:es exited with code 0
[build:types] yarn run build:types exited with code 0
Done in 9.52s.
  • downlevel script succeeds
Details
$ ls dist-types          
index.d.ts  runtimeConfig.browser.d.ts  runtimeConfig.d.ts  runtimeConfig.native.d.ts  Signer.d.ts

$ yarn build:types:downlevel
yarn run v1.22.18
$ downlevel-dts dist-types dist-types/ts3.4
Done in 1.49s.

$ ls dist-types             
index.d.ts  runtimeConfig.browser.d.ts  runtimeConfig.d.ts  runtimeConfig.native.d.ts  Signer.d.ts  ts3.4
  • clean command succeeds
Details
$ ls dist-*
dist-cjs:
index.js  runtimeConfig.browser.js  runtimeConfig.js  runtimeConfig.native.js  Signer.js

dist-es:
index.js  runtimeConfig.browser.js  runtimeConfig.js  runtimeConfig.native.js  Signer.js

dist-types:
index.d.ts  runtimeConfig.browser.d.ts  runtimeConfig.d.ts  runtimeConfig.native.d.ts  Signer.d.ts  ts3.4

$ yarn clean
yarn run v1.22.18
$ rimraf ./dist-* && rimraf *.tsbuildinfo
Done in 0.15s.

$ ls dist-*
zsh: no matches found: dist-*

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner May 24, 2022 14:50
@trivikr trivikr merged commit 953fd97 into aws:main May 24, 2022
@trivikr trivikr deleted the rds-signer-downlevel-script branch May 24, 2022 15:12
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants