Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): log when types not present in downlevel script #3307

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 11, 2022

Issue

Internal JS-3107
Follow-up in JS-3106

Description

Los instead of throwing error in downlevel script.

Reason for the change: We only build the packages to be published in new release automation scripts. Making this change to ignore when types are not available for any package. We'll run downlevel only for the changed packages as a follow-up.

Testing

$ cd private/aws-echo-service

$ rm -rf dist-types

$ cd ../../

$ yarn build:types:downlevel                                            
yarn run v1.22.17
$ node --es-module-specifier-resolution=node ./scripts/downlevel-dts
The types for "aws-echo-service" do not exist.

Done in 5.22s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 11, 2022 18:29
@trivikr trivikr changed the title fix(scripts): log instead of error in downlevel script fix(scripts): log when types not present in downlevel script Feb 11, 2022
@trivikr trivikr merged commit 68c0d1f into aws:main Feb 11, 2022
@trivikr trivikr deleted the log-instead-of-error-when-downleveling branch February 11, 2022 21:18
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants