Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib-storage): repair package.json runtimeConfig path #3352

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

Fzlw
Copy link
Contributor

@Fzlw Fzlw commented Feb 23, 2022

Issue

#3351

Description

When using the VITE build tool, @aws-sdk/lib-storage , The path of the browser field in package.json is incorrect, resulting in an error.
Can refer to @aws-sdk/client-cognito-identity package.json
repo address https://github.com/aws-samples/aws-sdk-js-notes-app/tree/main/packages/frontend

Testing

You can import the package in the above warehouse address, and change the value in package.json browser to reproduce the problem

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Fzlw Fzlw requested a review from a team as a code owner February 23, 2022 07:35
@trivikr trivikr changed the title fix: repair package.json runtimeConfig path fix(lib-storage): repair package.json runtimeConfig path Jun 16, 2022
@trivikr trivikr merged commit 76ac9db into aws:main Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants