Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn generate-clients fails with "method does not override or implement a method from a supertype" #922

Closed
trivikr opened this issue Feb 12, 2020 · 3 comments
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Feb 12, 2020

Describe the bug
yarn generate-clients fails with "method does not override or implement a method from a supertype"

SDK version number
The branch smithy-codegen with commit debed62

To Reproduce (observed behavior)

$ yarn generate-clients -m models
...
...
> Task :smithy-aws-typescript-codegen:compileJava FAILED

stderr: /local/home/trivikr/workspace/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsQuery.java:137: error: method does not override or implement a method from a supertype
    @Override

stderr:     ^
/local/home/trivikr/workspace/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsEc2.java:137: error: method does not override or implement a method from a supertype
    @Override
    ^
2 errors

FAILURE: Build failed with an exception.

Expected behavior
The command yarn generate-clients succeeds

@trivikr trivikr added the bug This issue is a bug. label Feb 12, 2020
@trivikr
Copy link
Member Author

trivikr commented Feb 12, 2020

This happens because #917 depends on smithy-lang/smithy-typescript#131, and I was trying to codegen for smithy-lang/smithy-typescript#132 by cherry-picking the commit

@trivikr
Copy link
Member Author

trivikr commented Feb 12, 2020

Will cherry-pick commit from smithy-lang/smithy-typescript#131 to unblock codegen for smithy-lang/smithy-typescript#132, while smithy-lang/smithy-typescript#128 is fixed

@trivikr trivikr closed this as completed Feb 12, 2020
@lock
Copy link

lock bot commented Feb 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

1 participant