-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change credentials.expiration from number to Date #1040
Conversation
Jest throws following error because of Date object babel-plugin-jest-hoist: The module factory of `jest.mock()` is not allowed to reference any out-of-scope variables
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #1040 +/- ##
==================================================
+ Coverage 91.42% 91.43% +0.01%
==================================================
Files 145 145
Lines 2858 2850 -8
Branches 507 506 -1
==================================================
- Hits 2613 2606 -7
+ Misses 245 244 -1
Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⛴
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Fixes #1037
Description of changes:
chore: change credentials.expiration from number to Date
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.