Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump cucumber to v1.3.3 #1070

Merged
merged 19 commits into from Apr 2, 2020
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 2, 2020

Issue #, if available:
N/A

Description of changes:

  • bump cucumber to v1.3.3
  • confirmed that all scenarios are successful
153 scenarios ( 153 passed )
534 steps ( 534 passed )
1m04.641s
Done in 67.26s.

Detailed output: cucumber-output.txt

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

153 scenarios (153 passed)
534 steps (534 passed)
Done in 92.02s.
Searched for this.Before\("([^"]*)", function\(
Replaced it with this.Before("$1", function(scenario,

Refs: cucumber/cucumber-js@ba08626
Failing scenarios:
features/dynamodb/tables.feature:6 # Scenario: Creating a table
features/dynamodb/tables.feature:40 # Scenario: Deleting the created table
features/dynamodbstreams/dynamodbstreams.feature:7 # Scenario: Listing streams
features/ec2/ec2.feature:21 # Scenario: Encrypted CopySnapshot
features/s3/objects.feature:139 # Scenario: Proxy support

153 scenarios (5 failed, 148 passed)
535 steps (5 failed, 12 skipped, 518 passed)
0m50.459s
153 scenarios (153 passed)
534 steps (534 passed)
0m59.660s
Done in 62.23s.
153 scenarios (153 passed)
534 steps (534 passed)
1m01.749s
Done in 64.31s.
153 scenarios (4 ambiguous, 149 passed)
534 steps (4 ambiguous, 1 skipped, 529 passed)
0m56.566s
replace "(@[^"]*)" with {tags: ["$1"]}
Refs: https://github.com/cucumber/cucumber-js/blob/v0.10.0/CHANGELOG.md

Failures:

1) Scenario: Bucket CORS - features/s3/buckets.feature:20
   Step: And I get the bucket CORS configuration - features/s3/buckets.feature:23
   Step Definition: features/s3/step_definitions/buckets.js:143
   Message:
     function timed out after 60000 milliseconds

153 scenarios (1 failed, 152 passed)
534 steps (1 failed, 6 skipped, 527 passed)
2m01.553s
(16:0): unexpected end of file, expected: #TagLine, #FeatureLine, #Comment, #Empty
path: /local/home/trivikr/workspace/aws-sdk-js-v3/features/dynamodb/crc32.feature
153 scenarios (153 passed)
534 steps (534 passed)
0m57.429s
Done in 60.03s.
@aws-sdk-js-automation

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #1070 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         146      146           
  Lines        2868     2868           
  Branches      511      511           
=======================================
  Hits         2624     2624           
  Misses        244      244

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbdb37...d7b294a. Read the comment docs.

@trivikr trivikr changed the title chore(deps-dev): bump cucumber to v1.3.1 chore(deps-dev): bump cucumber to v1.3.3 Apr 2, 2020
@aws-sdk-js-automation

This comment has been minimized.

@trivikr trivikr merged commit 96ec3d0 into aws:master Apr 2, 2020
@trivikr trivikr deleted the clean-cucumber branch April 2, 2020 16:40
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: d7b294a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lock
Copy link

lock bot commented Apr 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants