Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codegen for isa arrow functions #1120

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 27, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#163

Description of changes:
codegen for isa arrow functions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft April 27, 2020 20:31
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: cb2138e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #1120 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   73.54%   73.54%           
=======================================
  Files         283      283           
  Lines       13014    13014           
  Branches     3030     3030           
=======================================
  Hits         9571     9571           
  Misses       3443     3443           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c325e8b...cb2138e. Read the comment docs.

@trivikr trivikr marked this pull request as ready for review April 27, 2020 20:53
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trivikr trivikr merged commit d5f7e8f into aws:master Apr 28, 2020
@trivikr trivikr deleted the isa-arrow-function branch April 28, 2020 00:30
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants