Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use array for SetShape #1144

Merged
merged 2 commits into from
May 11, 2020
Merged

feat: use array for SetShape #1144

merged 2 commits into from
May 11, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 4, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#172

Description of changes:
Use array for SetShape

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 04d7cdb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented May 4, 2020

Codecov Report

Merging #1144 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
- Coverage   73.85%   73.75%   -0.11%     
==========================================
  Files         284      284              
  Lines       13175    12935     -240     
  Branches     3106     3001     -105     
==========================================
- Hits         9731     9540     -191     
+ Misses       3444     3395      -49     
Impacted Files Coverage Δ
protocol_tests/aws-ec2/models/index.ts 70.12% <ø> (ø)
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 63.98% <ø> (-0.96%) ⬇️
protocol_tests/aws-json/protocols/Aws_json1_1.ts 69.32% <ø> (ø)
protocol_tests/aws-query/models/index.ts 70.32% <ø> (ø)
protocol_tests/aws-query/protocols/Aws_query.ts 68.89% <ø> (-0.64%) ⬇️
protocol_tests/aws-restjson/models/index.ts 69.81% <ø> (ø)
...ol_tests/aws-restjson/protocols/Aws_restJson1_1.ts 65.81% <ø> (-0.03%) ⬇️
protocol_tests/aws-restxml/models/index.ts 68.53% <ø> (ø)
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 68.33% <ø> (-0.41%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a447a0...afb3267. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 2aaaba2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trivikr trivikr merged commit 0ab6a0f into aws:master May 11, 2020
@trivikr trivikr deleted the setshape-array branch May 11, 2020 17:52
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: afb3267
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants