Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant return statements from protocol.ts #1145

Merged
merged 4 commits into from
May 5, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 4, 2020

Issue #, if available:
N/A

Description of changes:
remove redundant return statements from protocol.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 1e6a48f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented May 4, 2020

Codecov Report

Merging #1145 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
+ Coverage   73.54%   73.88%   +0.33%     
==========================================
  Files         283      284       +1     
  Lines       13014    13187     +173     
  Branches     3030     3106      +76     
==========================================
+ Hits         9571     9743     +172     
- Misses       3443     3444       +1     
Impacted Files Coverage Δ
packages/util-body-length-browser/src/index.ts 71.42% <0.00%> (ø)
protocol_tests/aws-json/protocols/Aws_json1_1.ts 69.46% <0.00%> (+0.12%) ⬆️
protocol_tests/aws-query/protocols/Aws_query.ts 69.58% <0.00%> (+0.46%) ⬆️
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 65.00% <0.00%> (+0.47%) ⬆️
protocol_tests/aws-ec2/models/index.ts 70.12% <0.00%> (+0.50%) ⬆️
protocol_tests/aws-restjson/models/index.ts 69.81% <0.00%> (+0.72%) ⬆️
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 68.77% <0.00%> (+0.93%) ⬆️
...ol_tests/aws-restjson/protocols/Aws_restJson1_1.ts 65.90% <0.00%> (+1.15%) ⬆️
protocol_tests/aws-query/models/index.ts 70.32% <0.00%> (+1.18%) ⬆️
protocol_tests/aws-restxml/models/index.ts 68.53% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d2003...5b82eb7. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 5b82eb7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented May 5, 2020

This PR was merged as a follow-up to smithy-lang/smithy-typescript#176, instead of merging #1149

But the two PRs are similar, so won't be reverting

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants