Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry informational headers #1266

Merged
merged 5 commits into from
Jun 17, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 15, 2020

Issue #, if available:
Internal issue in JS-1816

Description of changes:
add retry informational headers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #1266 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage   73.04%   73.06%   +0.01%     
==========================================
  Files         287      287              
  Lines       12730    12737       +7     
  Branches     2922     2924       +2     
==========================================
+ Hits         9299     9306       +7     
  Misses       3431     3431              
Impacted Files Coverage Δ
packages/middleware-retry/src/defaultStrategy.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfaabc...90fbe76. Read the comment docs.

@trivikr

This comment has been minimized.

@trivikr trivikr closed this Jun 16, 2020
@trivikr trivikr reopened this Jun 16, 2020
@trivikr

This comment has been minimized.

@trivikr trivikr force-pushed the retry-informational-header-upstream branch from c297191 to 90fbe76 Compare June 16, 2020 19:05
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For future record: ttl from amz-sdk-request header is omitted from this PR.

@trivikr trivikr merged commit d055da7 into aws:master Jun 17, 2020
@trivikr trivikr deleted the retry-informational-header-upstream branch June 17, 2020 06:21
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

1 similar comment
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants