Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(region-provider): add extensive unit tests for region-provider #1280

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 17, 2020

Issue #, if available:
Refactored while investigating Retry Configuration task (internal JS-1813)

Description of changes:
add unit tests for region-provider

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title test(region-provider): add unit tests for region-provider test(region-provider): add extensive unit tests for region-provider Jun 17, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1280 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   73.04%   73.04%   -0.01%     
==========================================
  Files         287      287              
  Lines       12730    12729       -1     
  Branches     2922     2922              
==========================================
- Hits         9299     9298       -1     
  Misses       3431     3431              
Impacted Files Coverage Δ
packages/region-provider/src/defaultProvider.ts 100.00% <100.00%> (ø)
packages/region-provider/src/fromEnv.ts 100.00% <100.00%> (ø)
...kages/region-provider/src/fromSharedConfigFiles.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddfaabc...451e66e. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trivikr trivikr merged commit 5f61141 into aws:master Jun 17, 2020
@trivikr trivikr deleted the region-provider-update branch June 17, 2020 15:43
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

1 similar comment
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants