Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(efs): check for ValidationException #1288

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 22, 2020

Issue #, if available:
Refs: aws/aws-sdk-js#3321

Description of changes:
EFS started throwing ValidationException instead of BadRequest for deleteFileSystem operation on Saturday 06/20

Updating the tests after verifying that ValidationException is thrown also on AWS CLI:

$ date
Mon Jun 22 09:42:00 PDT 2020

$ aws --version
aws-cli/1.16.226 Python/3.7.3 Darwin/18.7.0 botocore/1.12.216

$ aws efs delete-file-system --file-system-id fake-id

An error occurred (ValidationException) when calling the DeleteFileSystem operation: 1 validation error detected: Value 'fake-id' at 'fileSystemId' failed to satisfy constraint: Member must satisfy regular expression pattern: ^fs-[0-9a-f]{8,40}

Ensured that integration tests are successful for EFS:

$ yarn test:integration-legacy --tags @efs
yarn run v1.22.4
$ cucumber-js --fail-fast --tags @efs
.........

2 scenarios (2 passed)
5 steps (5 passed)
0m00.143s
Done in 2.49s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from alexforsyth June 22, 2020 20:30
@codecov-commenter
Copy link

Codecov Report

Merging #1288 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
+ Coverage   73.04%   73.15%   +0.10%     
==========================================
  Files         287      290       +3     
  Lines       12730    12780      +50     
  Branches     2922     2933      +11     
==========================================
+ Hits         9299     9349      +50     
  Misses       3431     3431              
Impacted Files Coverage Δ
clients/client-s3/S3Client.ts 94.11% <0.00%> (ø)
clients/client-s3/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/region-provider/src/fromEnv.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 92.30% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/JsonProtocolClient.ts 92.30% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5ddfc...4ee40e0. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@trivikr trivikr merged commit 9e2614e into aws:master Jun 23, 2020
@trivikr trivikr deleted the update-efs-integ-tests branch June 23, 2020 03:52
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants