Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(credential-provider-imds): cases for fromInstanceMetadata #1318

Merged
merged 12 commits into from
Jul 2, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 2, 2020

Issue #, if available:
Done in preparation of IMDS v2 in JS-1802

Description of changes:

  • add extensive testing for fromInstanceMetadata
  • also converts functions to arrow functions and uses async-await

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1318 into master will increase coverage by 4.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
+ Coverage   73.04%   77.49%   +4.44%     
==========================================
  Files         287      286       -1     
  Lines       12730    11900     -830     
  Branches     2922     2601     -321     
==========================================
- Hits         9299     9222      -77     
+ Misses       3431     2678     -753     
Impacted Files Coverage Δ
packages/region-provider/src/fromEnv.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/property-provider/src/memoize.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 92.30% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/JsonProtocolClient.ts 92.30% <0.00%> (ø)
packages/middleware-retry/src/configurations.ts 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85866ff...3a6c651. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@trivikr trivikr changed the title test(credential-provider-imds): add cases for fromInstanceMetadata test(credential-provider-imds): cases for fromInstanceMetadata Jul 2, 2020
@trivikr trivikr merged commit d7fa8a7 into aws:master Jul 2, 2020
@trivikr trivikr deleted the refactor-fromInstanceMetadata branch July 2, 2020 16:11
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants