Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: using existing resources in e2e tests #1320

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Instead of creating resources(IAM, Identity pools) every time when e2e test suites run, we will call existing resources fixed in test account. This way we achieve low coupling with the test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from trivikr July 2, 2020 20:53
@codecov-commenter
Copy link

Codecov Report

Merging #1320 into master will increase coverage by 4.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   73.04%   77.49%   +4.44%     
==========================================
  Files         287      286       -1     
  Lines       12730    11898     -832     
  Branches     2922     2601     -321     
==========================================
- Hits         9299     9220      -79     
+ Misses       3431     2678     -753     
Impacted Files Coverage Δ
packages/region-provider/src/fromEnv.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/property-provider/src/memoize.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 92.30% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/JsonProtocolClient.ts 92.30% <0.00%> (ø)
packages/middleware-retry/src/configurations.ts 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fa8a7...9ad1432. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit d018293 into master Jul 2, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
@trivikr trivikr deleted the AllanFly120/use-existing-e2e-resources branch April 12, 2021 19:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants