Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run jest tests from all folders in cjs #1324

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 6, 2020

Issue #, if available:
Fixes: #1323

Description of changes:
run jest tests from all folders in cjs

$ cd packages/credential-provider-imds
$ yarn test  

yarn run v1.22.4
$ yarn build:cjs
$ tsc -p tsconfig.cjs.json
$ jest
 PASS  dist/cjs/fromContainerMetadata.spec.js
 PASS  dist/cjs/fromInstanceMetadata.spec.js
 PASS  dist/cjs/remoteProvider/httpGet.spec.js
 PASS  dist/cjs/remoteProvider/ImdsCredentials.spec.js
 PASS  dist/cjs/remoteProvider/retry.spec.js
 PASS  dist/cjs/remoteProvider/RemoteProviderInit.spec.js

Test Suites: 6 passed, 6 total
Tests:       33 passed, 33 total
Snapshots:   0 total
Time:        1.147s
Ran all test suites.
Done in 2.99s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1324 into master will decrease coverage by 11.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1324       +/-   ##
===========================================
- Coverage   89.34%   77.67%   -11.68%     
===========================================
  Files         152      286      +134     
  Lines        3145    11955     +8810     
  Branches      579     2622     +2043     
===========================================
+ Hits         2810     9286     +6476     
- Misses        335     2669     +2334     
Impacted Files Coverage Δ
...ts/aws-restjson/commands/RecursiveShapesCommand.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
...-query/commands/EmptyInputAndEmptyOutputCommand.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/endpoints.ts 82.14% <0.00%> (ø)
...s/aws-restjson/commands/NoInputAndOutputCommand.ts 100.00% <0.00%> (ø)
...stjson/commands/HttpPayloadWithStructureCommand.ts 100.00% <0.00%> (ø)
...otocol_tests/aws-query/commands/XmlEnumsCommand.ts 100.00% <0.00%> (ø)
...ws-restjson/commands/AllQueryStringTypesCommand.ts 88.23% <0.00%> (ø)
...http-handler/src/stream-collector/readable.mock.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/models/index.ts 73.07% <0.00%> (ø)
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d018293...fb5e38c. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Jul 6, 2020

codecov/project shows failure as coverage was falsely increased when the bug was introduced #1297 (comment)
The coverage is back to previous levels in 70s

@trivikr trivikr requested a review from alexforsyth July 6, 2020 16:07
@alexforsyth
Copy link
Contributor

Nice catch!

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest runs tests only from the *.spec.js files in the root folder
3 participants