Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add RN E2E test based on detox framework #1383

Merged
merged 11 commits into from Aug 5, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Jul 15, 2020

A sample RN app that confirms clients(currently only S3) works fine in RN 0.60. Please review tests/react-native/End2End/README.md for the steps to run this test.

@trivikr @alexforsyth Please checkout this branch and confirm for me whether you can run the tests locally.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP marked this pull request as draft July 15, 2020 01:44
@AllanZhengYP AllanZhengYP marked this pull request as ready for review August 4, 2020 21:32
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Merging #1383 into master will increase coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
+ Coverage   79.08%   79.58%   +0.50%     
==========================================
  Files         287      297      +10     
  Lines       11155    11342     +187     
  Branches     2360     2418      +58     
==========================================
+ Hits         8822     9027     +205     
+ Misses       2333     2315      -18     
Impacted Files Coverage Δ
packages/util-create-request/src/index.ts 100.00% <0.00%> (ø)
packages/middleware-signing/src/middleware.ts 91.66% <0.00%> (ø)
...iddleware-sdk-s3-control/src/prepend-account-id.ts 86.95% <0.00%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 91.30% <0.00%> (ø)
...dk-transcribe-streaming/src/middleware-endpoint.ts 95.23% <0.00%> (ø)
...edential-provider-imds/src/fromInstanceMetadata.ts
...rovider-imds/src/remoteProvider/ImdsCredentials.ts
...al-provider-imds/src/remoteProvider/httpRequest.ts
...dential-provider-imds/src/fromContainerMetadata.ts
...ider-imds/src/remoteProvider/RemoteProviderInit.ts
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57aedcc...6b32345. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 8991f25 into aws:master Aug 5, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants