New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add RN E2E test based on detox framework #1383
Merged
AllanZhengYP
merged 11 commits into
aws:master
from
AllanZhengYP:AllanFly120/rn-integ-test
Aug 5, 2020
Merged
test: add RN E2E test based on detox framework #1383
AllanZhengYP
merged 11 commits into
aws:master
from
AllanZhengYP:AllanFly120/rn-integ-test
Aug 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
AllanFly120/rn-integ-test
branch
from
July 20, 2020 20:41
adae48b
to
42b1ad5
Compare
trivikr
approved these changes
Aug 4, 2020
alexforsyth
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
AllanZhengYP
force-pushed
the
AllanFly120/rn-integ-test
branch
from
August 5, 2020 22:25
6eabce6
to
49be401
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sample RN app that confirms clients(currently only S3) works fine in RN 0.60. Please review tests/react-native/End2End/README.md for the steps to run this test.
@trivikr @alexforsyth Please checkout this branch and confirm for me whether you can run the tests locally.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.