Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventstream-serde-config-resolver): simplify and add tests #1403

Merged
merged 1 commit into from Aug 6, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 28, 2020

Issue #, if available:
N/A

Description of changes:
simplify and add tests in eventstream-serde-config-resolver

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #1403 into master will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1403      +/-   ##
==========================================
+ Coverage   79.08%   79.56%   +0.47%     
==========================================
  Files         287      297      +10     
  Lines       11155    11328     +173     
  Branches     2360     2414      +54     
==========================================
+ Hits         8822     9013     +191     
+ Misses       2333     2315      -18     
Impacted Files Coverage Δ
packages/util-create-request/src/index.ts 100.00% <0.00%> (ø)
packages/middleware-signing/src/middleware.ts 91.66% <0.00%> (ø)
...iddleware-sdk-s3-control/src/prepend-account-id.ts 86.95% <0.00%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 91.30% <0.00%> (ø)
...dk-transcribe-streaming/src/middleware-endpoint.ts 95.23% <0.00%> (ø)
...al-provider-imds/src/remoteProvider/httpRequest.ts
...dential-provider-imds/src/fromContainerMetadata.ts
...edential-provider-imds/src/remoteProvider/retry.ts
...rovider-imds/src/remoteProvider/ImdsCredentials.ts
...edential-provider-imds/src/fromInstanceMetadata.ts
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b2e87...c5cff31. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Jul 28, 2020

CodeBuild CI re-rerun was successful (details)

@trivikr trivikr force-pushed the eventstream-serde-resolver-tests branch from 58e4b6a to c5cff31 Compare July 29, 2020 20:15
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the tests!

@trivikr trivikr merged commit 7783c69 into aws:master Aug 6, 2020
@trivikr trivikr deleted the eventstream-serde-resolver-tests branch August 6, 2020 20:45
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants