Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-s3): add useArnRegion config #1420

Merged
merged 11 commits into from Aug 11, 2020
Merged

Conversation

AllanZhengYP
Copy link
Contributor

Replaces #1418

Description of changes:

  • add a node-config-provider package: Load specified config from environemnt variables, and fall back to shared INI config files(credentials file and config file).
  • add a useArnRegion config to the S3 client. Similar to V2 s3UseArnRegion config. It loads config from client config, environment variables and shared INI files in fallback manner.

TODO: in separate PR, I will move region, maxAttempt, retryMode config to use node-config-provider package and get rid of their config provider packages

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #1420 into master will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
+ Coverage   79.08%   79.69%   +0.61%     
==========================================
  Files         287      302      +15     
  Lines       11155    11402     +247     
  Branches     2360     2438      +78     
==========================================
+ Hits         8822     9087     +265     
+ Misses       2333     2315      -18     
Impacted Files Coverage Δ
packages/util-create-request/src/index.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 66.94% <0.00%> (ø)
packages/middleware-signing/src/middleware.ts 91.66% <0.00%> (ø)
protocol_tests/aws-query/protocols/Aws_query.ts 66.72% <0.00%> (ø)
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 66.25% <0.00%> (ø)
...ocol_tests/aws-restjson/protocols/Aws_restJson1.ts 61.19% <0.00%> (ø)
...s/middleware-bucket-endpoint/src/configurations.ts 100.00% <0.00%> (ø)
...iddleware-sdk-s3-control/src/prepend-account-id.ts 86.95% <0.00%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 91.30% <0.00%> (ø)
...dk-transcribe-streaming/src/middleware-endpoint.ts 95.23% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f700d...61cffe9. Read the comment docs.

@AllanZhengYP
Copy link
Contributor Author

CodeBuild actually succeeds after retry

packages/middleware-bucket-endpoint/src/configurations.ts Outdated Show resolved Hide resolved
packages/node-config-provider/src/fromEnv.ts Show resolved Hide resolved
clients/client-s3/package.json Outdated Show resolved Hide resolved
packages/node-config-provider/src/fromStatic.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
@trivikr trivikr deleted the s3-access-point-config branch May 14, 2021 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants