New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client-s3): add useArnRegion config #1420
Conversation
6e37ec0
to
501304a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
+ Coverage 79.08% 79.69% +0.61%
==========================================
Files 287 302 +15
Lines 11155 11402 +247
Branches 2360 2438 +78
==========================================
+ Hits 8822 9087 +265
+ Misses 2333 2315 -18
Continue to review full report at Codecov.
|
501304a
to
93bb144
Compare
ee13e59
to
106fdeb
Compare
CodeBuild actually succeeds after retry |
8c0ad49
to
106fdeb
Compare
…endpoint middleware
106fdeb
to
61cffe9
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Replaces #1418
Description of changes:
node-config-provider
package: Load specified config from environemnt variables, and fall back to shared INI config files(credentials file and config file).useArnRegion
config to the S3 client. Similar to V2 s3UseArnRegion config. It loads config from client config, environment variables and shared INI files in fallback manner.TODO: in separate PR, I will move
region
,maxAttempt
,retryMode
config to usenode-config-provider
package and get rid of their config provider packagesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.