Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eventstream-serde-browser): set module to dist output #1434

Merged
merged 1 commit into from Aug 12, 2020

Conversation

hmaurer
Copy link
Contributor

@hmaurer hmaurer commented Aug 11, 2020

Description of changes:
The module property of eventstream-serde-browser/package.json was not set to ./dist/es/index.js, which is what Typescript (tsconfig.es.json) is configured to output the ES bundle to. This pull request updates it.

Question: should I version bump the package as well?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1434 into master will increase coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
+ Coverage   79.08%   79.59%   +0.50%     
==========================================
  Files         287      298      +11     
  Lines       11155    11345     +190     
  Branches     2360     2418      +58     
==========================================
+ Hits         8822     9030     +208     
+ Misses       2333     2315      -18     
Impacted Files Coverage Δ
packages/util-create-request/src/index.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 66.94% <0.00%> (ø)
packages/middleware-signing/src/middleware.ts 91.66% <0.00%> (ø)
protocol_tests/aws-query/protocols/Aws_query.ts 66.72% <0.00%> (ø)
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 66.25% <0.00%> (ø)
...ocol_tests/aws-restjson/protocols/Aws_restJson1.ts 61.19% <0.00%> (ø)
...iddleware-sdk-s3-control/src/prepend-account-id.ts 86.95% <0.00%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 91.30% <0.00%> (ø)
...dk-transcribe-streaming/src/middleware-endpoint.ts 95.23% <0.00%> (ø)
...rovider-imds/src/remoteProvider/ImdsCredentials.ts
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f700d...7167127. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmaurer Thanks for the PR 🎉. You don't need to bump the package version

@AllanZhengYP AllanZhengYP merged commit 90c685a into aws:master Aug 12, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants