Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy tweaks in s3-request-presigner README #1440

Merged
merged 1 commit into from Aug 17, 2020
Merged

Conversation

jblz
Copy link
Contributor

@jblz jblz commented Aug 14, 2020

  • Signify that the second example is ES6-specific -- not Typescript
  • Minor grammar corrections:
    • "when instantiating" vs. "when instantiate"
    • "the configuration of an" vs. "the configurations of an"
    • "an existing client" vs. "an existing clients"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Signify that the second example is ES6-specific -- not Typescript
* Minor grammar corrections:
    * "when instantiating" vs. "when instantiate"
    * "the configuration of an" vs. "the configurations of an"
    * "an existing client" vs. "an existing clients"
@codecov-commenter
Copy link

Codecov Report

Merging #1440 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
- Coverage   79.69%   79.67%   -0.02%     
==========================================
  Files         302      299       -3     
  Lines       11402    11391      -11     
  Branches     2438     2431       -7     
==========================================
- Hits         9087     9076      -11     
  Misses       2315     2315              
Impacted Files Coverage Δ
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/config-resolver/src/RegionConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/region-provider/src/fromEnv.ts
packages/region-provider/src/defaultProvider.ts
...kages/region-provider/src/fromSharedConfigFiles.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d79645...710d457. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit e4f57d0 into aws:master Aug 17, 2020
@AllanZhengYP
Copy link
Contributor

Hi @jblz, Thank you for the PR. 🎉

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants