Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination global types #1443

Merged
merged 4 commits into from Aug 19, 2020

Conversation

alexforsyth
Copy link
Contributor

Issue #, if available:

Description of changes:
Adding global paginator types.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #1443 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
- Coverage   79.69%   79.67%   -0.02%     
==========================================
  Files         302      299       -3     
  Lines       11402    11391      -11     
  Branches     2438     2431       -7     
==========================================
- Hits         9087     9076      -11     
  Misses       2315     2315              
Impacted Files Coverage Δ
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-query/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restxml/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/config-resolver/src/RegionConfig.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5478012...dddddf5. Read the comment docs.

@alexforsyth
Copy link
Contributor Author

Build fails due to codecov. We dont care in this case

@alexforsyth alexforsyth merged commit d12f9ba into aws:master Aug 19, 2020
@alexforsyth alexforsyth deleted the alexfors/pagination-types branch August 19, 2020 16:50
@alexforsyth alexforsyth restored the alexfors/pagination-types branch August 19, 2020 19:17
alexforsyth added a commit that referenced this pull request Aug 19, 2020
alexforsyth added a commit that referenced this pull request Aug 19, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants