Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removeSync in case of directory in copy-to-clients #1452

Merged
merged 1 commit into from Aug 19, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 19, 2020

Issue #, if available:
Internal issue JS-2016

Description of changes:
removeSync in case of directory in copy-to-clients

As detailed in internal issue JS-2016, the current copy-to-clients script doesn't remove commands which could have been removed from models. This PR ensures that the directories are deleted before individual files are copied over. The command ensureDirSync doesn't need to be run, as copySync would create the directory.

Testing:
Verified that the files GetPredictionCommand.ts and PutModelCommand.ts were removed while generating client for frauddetector using updated models.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore: removeSync in case of directory in copy-to-clients fix: removeSync in case of directory in copy-to-clients Aug 19, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1452 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
- Coverage   79.69%   79.62%   -0.08%     
==========================================
  Files         302      296       -6     
  Lines       11402    11377      -25     
  Branches     2438     2427      -11     
==========================================
- Hits         9087     9059      -28     
- Misses       2315     2318       +3     
Impacted Files Coverage Δ
packages/middleware-retry/src/configurations.ts 90.62% <0.00%> (-9.38%) ⬇️
protocol_tests/aws-ec2/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-query/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restxml/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/endpoints.ts 81.48% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5478012...eb5c03a. Read the comment docs.

@trivikr trivikr merged commit 8a0febd into aws:master Aug 19, 2020
@trivikr trivikr deleted the removeSync-copy-to-clients branch August 19, 2020 21:33
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants