New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s3-request-presigner): add getSignedUrl() from client and commands #1454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
==========================================
+ Coverage 79.77% 79.80% +0.02%
==========================================
Files 297 298 +1
Lines 11480 11502 +22
Branches 2470 2475 +5
==========================================
+ Hits 9158 9179 +21
- Misses 2322 2323 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor comments. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit
936b2ff
to
65ace72
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Add getSignedUrl() to get signed url from client and command. The existing presigning method using
S3RequestPresigner
only takes existing HTTP request. It has 2 problems:S3RequestPresigner
they usually need to use@aws-sdk/util-create-request
dependency to get the HTTP request from command and client.useArnRegion
"), the logic will be too complexed.getSignedUrl
also provide a familiar method compared to V2 SDK.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.