fix(property-provider): memoize provider after the first evoke #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
=======================================
Coverage 79.80% 79.81%
=======================================
Files 298 298
Lines 11502 11507 +5
Branches 2475 2477 +2
=======================================
+ Hits 9179 9184 +5
Misses 2323 2323
Continue to review full report at Codecov.
|
trivikr
reviewed
Aug 26, 2020
|
The retried build succeeds. Link for build logs |
trivikr
approved these changes
Aug 26, 2020
|
Ref: Original build failed because of issue #1460 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1466
Description of changes:
This change makes the memoize function loads the value after the first invoke instead of immediately when calling
memoize().Detailed root cause is stated in the original issue: #1466 (comment). This issue was not caught because all of the environments we run CI, and developers machine, already has
AWS_REGIONvalue set.To prevent it happens again, we need to check and clean the environment of our CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.