chore: remove __type and isa from shapes

[trivikr]

Issue #, if available:

Following PRs should be merged before this PR:

• add tests folder in overwritablePathnames fix(codegen): add tests folder in overwritablePathnames #1500
• re-add cloudwatch-events models file fix: re-add cloudwatch-events models file #1501
• Remove __type and isa function Remove __type and isa function  smithy-lang/smithy-typescript#208

Description of changes:
remove __type and isa from shapes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

Merging #1502 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   79.80%   79.63%   -0.17%     
==========================================
  Files         298      299       +1     
  Lines       11502    11634     +132     
  Branches     2475     2483       +8     
==========================================
+ Hits         9179     9265      +86     
- Misses       2323     2369      +46     

Impacted Files	Coverage Δ
...l_tests/aws-json/commands/EmptyOperationCommand.ts	90.00% <0.00%> (-10.00%)	⬇️
...ts/aws-query/commands/NoInputAndNoOutputCommand.ts	90.00% <0.00%> (-10.00%)	⬇️
.../aws-restxml/commands/NoInputAndNoOutputCommand.ts	90.00% <0.00%> (-10.00%)	⬇️
...aws-restjson/commands/NoInputAndNoOutputCommand.ts	90.00% <0.00%> (-10.00%)	⬇️
protocol_tests/aws-ec2/commands/XmlBlobsCommand.ts	95.00% <0.00%> (-5.00%)	⬇️
protocol_tests/aws-ec2/commands/XmlEnumsCommand.ts	95.00% <0.00%> (-5.00%)	⬇️
protocol_tests/aws-ec2/commands/XmlListsCommand.ts	95.00% <0.00%> (-5.00%)	⬇️
...rotocol_tests/aws-query/commands/XmlMapsCommand.ts	95.00% <0.00%> (-5.00%)	⬇️
...otocol_tests/aws-query/commands/XmlBlobsCommand.ts	95.00% <0.00%> (-5.00%)	⬇️
...otocol_tests/aws-query/commands/XmlEnumsCommand.ts	95.00% <0.00%> (-5.00%)	⬇️
... and 115 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead3816...e70c79f. Read the comment docs.

[AllanZhengYP]

Can we keep the __type and isa() in exceptions? Without isa() the error handling experience would have a regress. For example, users cannot use type predicate when handling errors with special keys in their interface. Previously, users can:

import { SpecialException } from "client-foo";
try {
 ...
} catch (e) {
  if (SpecialException.isa(e)) {
   const key =  e.someSpecialKey // someSpecialKey is available in type
  }
}

[trivikr]

Can we keep the __type and isa() in exceptions?

The __type is not required in Exceptions, as name property is populated with the same value.

Using instanceof is a better solution than using isa()
MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error#Handling_a_specific_error

[trivikr]

Using instanceof is a better solution than using isa()

Actually, comparing err.name instead of instanceof is also used in JavaScript ecosystem as explained in https://javascript.info/custom-errors#extending-error

// ...
// instead of (err instanceof SyntaxError)
} else if (err.name == "SyntaxError") { // (*)
// ...

Although instanceof is future-proof, and it's better to have that supported.

[AllanZhengYP]

Both instanceof and err.name work in this case. But instanceof will have better type support. If we are going with this path, let's add the support sooner than later: Generating all the error shapes in classes(or constructors) instead of structures.

[trivikr]

Generating all the error shapes in classes(or constructors) instead of structures.

Created a feature request for it at #1506

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.