Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util-dynamodb): create BigInt from string value instead of number #1544

Merged
merged 2 commits into from Sep 30, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 29, 2020

Issue #, if available:
Fixes: #1543

Description of changes:
creates BigInt from string value instead of number

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Reason: BigInt(Number.MAX_VALUE.toString()); throws
Uncaught SyntaxError: Cannot convert 1.7976931348623157e+308 to a BigInt
@codecov-commenter
Copy link

Codecov Report

Merging #1544 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1544      +/-   ##
==========================================
+ Coverage   79.84%   79.93%   +0.08%     
==========================================
  Files         304      306       +2     
  Lines       11753    11804      +51     
  Branches     2511     2527      +16     
==========================================
+ Hits         9384     9435      +51     
  Misses       2369     2369              
Impacted Files Coverage Δ
packages/middleware-host-header/src/index.ts 80.00% <ø> (ø)
packages/util-dynamodb/src/convertToNative.ts 100.00% <100.00%> (ø)
packages/util-dynamodb/src/unmarshall.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09e0da...a26de23. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@trivikr trivikr merged commit 76c0068 into aws:master Sep 30, 2020
@trivikr trivikr deleted the fix-bigint-unmarshall branch September 30, 2020 19:57
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(util-dynamodb): BigInt value increases by 1n after marshall+unmarshall
3 participants