Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(util-dynamodb): marshall and unmarshall in convertToAttrToNative #1548

Merged
merged 2 commits into from Oct 2, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 1, 2020

Issue #, if available:
Will help catch issues like #1543

Description of changes:
test convertToAttr and back to convertToNative

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1548 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   79.84%   79.93%   +0.08%     
==========================================
  Files         304      306       +2     
  Lines       11753    11804      +51     
  Branches     2511     2527      +16     
==========================================
+ Hits         9384     9435      +51     
  Misses       2369     2369              
Impacted Files Coverage Δ
packages/middleware-host-header/src/index.ts 80.00% <0.00%> (ø)
packages/util-dynamodb/src/convertToNative.ts 100.00% <0.00%> (ø)
packages/util-dynamodb/src/unmarshall.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c0068...3d7eef6. Read the comment docs.

@trivikr trivikr merged commit 2d9b200 into aws:master Oct 2, 2020
@trivikr trivikr deleted the convertToAttrToNative branch October 2, 2020 18:27
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants