Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw 3XX redirection as errors explicitly #1591

Merged
merged 1 commit into from Oct 21, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Codegen change: smithy-lang/smithy-typescript#222
Resolves: #1446 #1385

Description of changes:
SDK throws 3xx response as exceptions instead of failing silently. This behavior aligns with other Smithy SDK like Go v2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

Merging #1591 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
- Coverage   79.92%   79.73%   -0.19%     
==========================================
  Files         313      324      +11     
  Lines       11839    12056     +217     
  Branches     2504     2547      +43     
==========================================
+ Hits         9462     9613     +151     
- Misses       2377     2443      +66     
Impacted Files Coverage Δ
packages/util-create-request/src/foo.fixture.ts 83.33% <0.00%> (ø)
lib/storage/src/data-chunk/buffer-helper.ts 91.66% <0.00%> (ø)
lib/storage/src/upload/defaults.ts 100.00% <0.00%> (ø)
lib/storage/src/upload/service-clients/Uploader.ts 40.47% <0.00%> (ø)
...age/src/upload/service-clients/S3ClientUploader.ts 52.63% <0.00%> (ø)
lib/storage/src/index.ts 100.00% <0.00%> (ø)
...b/storage/src/upload/service-clients/S3Uploader.ts 77.77% <0.00%> (ø)
lib/storage/src/upload/Upload.ts 60.52% <0.00%> (ø)
lib/storage/src/utils/bytelength.ts 50.00% <0.00%> (ø)
lib/storage/src/data-chunk/readable-helper.ts 92.30% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07e719...bd5e87a. Read the comment docs.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 GetObject without region resolves mostly empty response with 301 redirect.
3 participants